tf2: Add tf2_geometry_msgs dependency #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf2/include/tf2/impl/utils.h includes tf2_geometry_msgs/tf2_geometry_msgs.h but the dependency is missing
|
@ros-pull-request-builder retest this please |
|
Thanks for catching that. It is a problem. However adding this dependency creates a circular dependency since |
|
Yeah agreed, seems like some restructuring is required so I'll let you guys do it the right way :) |
tfoote
requested changes
Jul 24, 2017
|
I'm going to close this as there's now a ticket tracking it in #275 with a discussion of a better way to resolve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf2/include/tf2/impl/utils.hincludestf2_geometry_msgs/tf2_geometry_msgs.hbut the dependency is missing